Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax DKG ceremony constraints #168

Closed
wants to merge 1 commit into from
Closed

Relax DKG ceremony constraints #168

wants to merge 1 commit into from
+711 −298

Conversation

piotr-roslaniec
Copy link

@piotr-roslaniec piotr-roslaniec commented Jan 10, 2024 •
edited
Loading

Type of PR:

  • Feature

Required reviews:

  • 2

What this does:

  • DKG now operates under relaxed ceremony constraints, where instead of n-of-m we allow for n-of-[m, validators.len()] to be considered a successful ceremony
  • In this new regime, the old shares_num is effectively replaced by validators.len(), and from now on shares_num denotes the minimum number of shares (or validators) that the DKG ceremony accommodates

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@piotr-roslaniec piotr-roslaniec changed the base branch from main to chores January 10, 2024 10:48
@piotr-roslaniec piotr-roslaniec force-pushed the relax-dkg-ceremony branch 3 times, most recently from 6a539a4 to df3247f Compare January 10, 2024 11:08
@piotr-roslaniec piotr-roslaniec changed the title feat(ferveo): derive eq in DkgPublicKey Relax DKG ceremony constraints Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024 •
edited
Loading

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (87c5f34) 78.10% compared to head (17a18cd) 78.54%.

Files Patch % Lines
ferveo/src/bindings_python.rs 0.00% 10 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 3 Missing ⚠️
ferveo/src/dkg.rs 96.90% 3 Missing ⚠️
ferveo/src/pvss.rs 90.90% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           chores     #168      +/-   ##
==========================================
+ Coverage   78.10%   78.54%   +0.43%     
==========================================
  Files          23       23              
  Lines        5097     5252     +155     
==========================================
+ Hits         3981     4125     +144     
- Misses       1116     1127      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec deleted the branch nucypher:chores January 18, 2024 17:44
@piotr-roslaniec
Copy link
Author

Replaced by #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-roslaniec @codecov-commenter